Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchMode.BETWEEN implementation #2303

Merged
merged 3 commits into from
May 20, 2024

Conversation

christopher-oliveira
Copy link

I'm sending a MatchMode.BETWEEN implementation for SpringDataJpaLazyDataModel.
Example:
<p:column headerText="Data do Pagamento"
sortBy="#{obj.pagoEm}"
field="pagoEm"
filterMatchMode="between">
<f:facet name="filter">
<p:datePicker flex="true" readonlyInput="true" selectionMode="range" styleClass="ui-custom-filter"/>
</f:facet>
<commons:outputTextDate value="#{obj.pagoEm}"/>
</p:column>

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 60.54%. Comparing base (b7edc69) to head (1bcabe1).
Report is 95 commits behind head on 5.3.x.

Files Patch % Lines
...infaces/primefaces/SpringDataJpaLazyDataModel.java 29.16% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              5.3.x    #2303      +/-   ##
============================================
+ Coverage     60.26%   60.54%   +0.28%     
  Complexity       31       31              
============================================
  Files            96       96              
  Lines          1588     1612      +24     
  Branches        158      164       +6     
============================================
+ Hits            957      976      +19     
- Misses          596      600       +4     
- Partials         35       36       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsgrefer larsgrefer merged commit f5c9656 into joinfaces:5.3.x May 20, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants