Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test evaluation #1187

Merged
merged 1 commit into from Mar 25, 2024
Merged

Change test evaluation #1187

merged 1 commit into from Mar 25, 2024

Conversation

johnynek
Copy link
Owner

related to #1180

Just using parallelism doesn't work because MatchlessToValue uses mutable state and it seems that threading breaks.

Considering how to make that work when values can be evaluated in parallel requires some thought. Probably using Eval at all won't work, and we will need something smarter.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.55%. Comparing base (04a0e87) to head (4b541bc).
Report is 19 commits behind head on main.

Files Patch % Lines
...i/src/main/scala/org/bykn/bosatsu/PathModule.scala 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   91.32%   91.55%   +0.23%     
==========================================
  Files          96       96              
  Lines       11846    12014     +168     
  Branches     2675     2766      +91     
==========================================
+ Hits        10818    11000     +182     
+ Misses       1028     1014      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek johnynek merged commit a472c8d into main Mar 25, 2024
8 of 9 checks passed
@johnynek johnynek deleted the oscar/20240324_change_test_eval branch March 25, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants