add complete queue property checks #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
commented
Mar 16, 2024
test_workspace/Nat.bosatsu
Outdated
| case Zero: acc | ||
| case Succ(n): | ||
| # (n + 1) / 2 = n/2 if n is even, else n/2 + 1 | ||
| if is_even(n): loop(n, acc) |
There was a problem hiding this comment.
we know that every other item is even. This algorithm is quadratic, but we can make it O(N).
johnynek
commented
Mar 16, 2024
| @@ -48,7 +50,7 @@ def fold_Queue(Queue(f, b): Queue[a], init: b, fold_fn: (b, a) -> b) -> b: | |||
| b.reverse().foldLeft(front, fold_fn) | |||
|
|
|||
| def reverse_Queue(Queue(f, b): Queue[a]) -> Queue[a]: | |||
| Queue(b.reverse(), f.reverse()) | |||
There was a problem hiding this comment.
this bug was detected by property checks! Yay!
johnynek
commented
Mar 16, 2024
| rev_rand = smaller.map_Rand(reverse_Queue) | ||
| one_of(pop_rand, [push_rand, rev_rand]) | ||
|
|
||
| rand_Queue_Int: Rand[Queue[Int]] = rand_Queue_depth(int_to_Nat(50)) |
There was a problem hiding this comment.
this is building a pretty giant tree perhaps... definitely the checks take a while to run.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
+ Coverage 91.32% 91.48% +0.16%
==========================================
Files 96 96
Lines 11846 12010 +164
Branches 2675 2778 +103
==========================================
+ Hits 10818 10987 +169
+ Misses 1028 1023 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to exercise property checks by adding more checks for Queue. Definitely it can be tricky to implement functions in Bosatsu due to the totality requirements. For instance, implementing Rand::one_of was a bit tricky. You have to find the right recursion strategy. I was trying to make sampling O(log N), so I needed to make a tree. To do that, I used BinNat to be able to recur on half the size of the items, rather than the naive approach.
I also found a nice trick.
Define:
then we can consume args and magically produce things by doing
todo((foo, bar))and runtype-check. Then it fails at runtime since we don't actually implement todo. We could use this strategy except possibly make that function only exist in predef when running type-check (which doesn't output anything).