Enhancement: API Functionality and Pagination Support in Handball Summaries #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the API class constructor in `API.py` to improve parameter handling and configuration flexibility. - Updated `_make_request` method for better parameter integration and added debugging prints for path and full URI. - Modified `get_season_summaries` in `Handball.py` to support pagination. Implemented optional `start` and `limit` parameters to handle Sportradar's new API limits on data requests. - Note: These updates address recent changes in Sportradar API, especially for Handball and potentially other sports. Michael Adams <github.com/mad4ms>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request introduces significant enhancements to the Sportradar API's functionality, specifically targeting improvements in parameter handling and the integration of pagination in Handball summaries. These changes aim to adapt to recent updates in the Sportradar API and provide more flexibility and control to users of the API wrapper.
Key Changes
Refactoring of API Class Constructor (API.py):
Pagination in Handball Summaries (Handball.py):
get_season_summariesmethod to support pagination.startandlimitparameters, addressing Sportradar's new API limits on data requests.Additional Notes
These updates are in response to recent changes in Sportradar's API, especially regarding Handball and potentially affecting other sports. The primary goal is to ensure the API wrapper remains functional and efficient, adhering to the latest API standards set by Sportradar.