Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for VS Code 1.26 #13

Merged
merged 3 commits into from
Feb 11, 2019
Merged

Update for VS Code 1.26 #13

merged 3 commits into from
Feb 11, 2019

Conversation

dennisheer
Copy link
Contributor

@dennisheer dennisheer commented Aug 14, 2018

Use extensionPack instead of extensionDependencies in package.json.

As per the VS Code 1.26 release notes "[t]his will make it much simpler and easier for users to manage an Extension Pack and its bundled extensions. It allows deactivating and uninstalling extensions installed by the extension pack without affecting the extension pack itself."

"An Extension Pack should not have any functional dependencies with its bundled extensions and they should be manageable independent of the pack." "This needs adoption by Extension Packs":

Since I don't have any experience in developing VS Code extensions I wasn't able to successfully test this on my machine. Pressing F5 as described in the vsc-extension-quickstart.md worked but didn't show the expected results.

The extensionPack feature had been discussed in microsoft/vscode#48430

Can anyone please confirm this is working? What about downwards compatibility?

Resolves #10

Dennis Heer added 3 commits August 14, 2018 17:59
Use "extensionPack" instead of "extensionDependencies" in package.json.

This will make it much simpler and easier for users to manage an Extension Pack and its bundled extensions.
It allows deactivating and uninstalling extensions installed by the extension pack without affecting the extension pack itself.

See https://code.visualstudio.com/updates/v1_26#_extension-packs-revisited
VS Code already provides intellisense for paths.
@johnpapa johnpapa merged commit 191b94d into johnpapa:master Feb 11, 2019
@johnpapa
Copy link
Owner

thnks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants