Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint recommendations #782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ESLint recommendations #782

wants to merge 1 commit into from

Conversation

dopry
Copy link

@dopry dopry commented Oct 7, 2016

This is the output of the recommended jshint and jscs options after passing through polyjuice. I also added a .eslintrc which can be downloaded from the repo as well.

Let me know if this is acceptable or if I should make any additional refinements.

closes #770
closes #696
partially addresses #732, but JSCS should probably be removed from the styleguide after a deprecation period since it is not a part of ESLint.

@AdriVanHoudt
Copy link

Why not reference https://www.npmjs.com/package/eslint-plugin-angular?

@dopry
Copy link
Author

dopry commented Oct 28, 2016

Because it's much simpler to convert the existing jshint rules to eslint
and doesn't add as many additional dependencies to a project. Feel free to
submit a PR with eslint-plugin-angular if you think it's a better solution.

On Oct 24, 2016 5:44 AM, "Adri Van Houdt" notifications@github.com wrote:

Why not reference https://www.npmjs.com/package/eslint-plugin-angular?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#782 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXqOGZ0tAqf81ImvlTRC7PPG5RJnOVXks5q3IvigaJpZM4KRcAA
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint configuration Eslint Options File
2 participants