$mol_view added #135
Open
$mol_view added #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmichel
reviewed
Jun 29, 2019
| @@ -437,6 +437,20 @@ var d41d8cd98f00b204e9800998ecf8427e_LibraryDetectorTests = { | |||
| } | |||
| }, | |||
|
|
|||
| '$mol_view': { | |||
There was a problem hiding this comment.
Suggested change
| '$mol_view': { | |
| '$mol': { |
Since the documentation for this library refers to itself as $mol, the name should reflect that.
There was a problem hiding this comment.
$mol is the namespace. There are many libraries. $mol_view (view components base class) is one of them.
johnmichel
reviewed
Jun 29, 2019
| icon: 'mol', | ||
| url: 'http://mol.js.org/', | ||
| test: function(win) { | ||
| if (win.$mol_view) { |
There was a problem hiding this comment.
Suggested change
| if (win.$mol_view) { | |
| if (win.$mol_view || win.document.querySelector('$mol_view_root')) { |
Would be preferable to having two, single-condition if blocks here.
There was a problem hiding this comment.
I think 2 simplest conditions are easier to understand than 1 complex condition.
|
Why not accept it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://mol.js.org