Mobile Chrome fails to download unsafe files #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome browser supplied with modern android devices (4.0 and newer) provides a warning for the user if the browser starts downloading an 'unsafe' file (like an .apk file) that requires user confirmation to continue.
The way the plugin handles the download on android devices (by opening and closing a new browser window) the warning is hidden before the user has a chance to confirm, in effect no file is downloaded.
I believe mobile Chrome browser can handle download via an iframe just as good as a desktop version and this is fixed by detecting it's user agent and using the iframe download method rather than the android-stock-browser-specific one.