Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(dingz): don't add D1 if
not_connected
- The dingz FW/API `1.2.x` allows users to hide dimmers from the UI - At the same time, output/input 1 can be configured as well when the input is disabled and the dimmer doesn't exist - check whether `output` of the dimmer is enabled - in that case, `D1` shouldn't be added at all - fixes #143 - implements part of #118 Thanks @granturismo0 for reporting
- Loading branch information
aef7298
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to test this, would appreciate if you can help @granturism0. Pushed as
homebridge-dingz@2.0.2-nightly.0
withnightly
tag tonpm
.PS: I don't yet implement the full code to also remove D1 if it exists but is set to
not_connected
. I don't think it belongs in this corner of the code. If you configure D1 as I1 and then configure it back, it should first be removed and then not be added again. Alternatively, you can, of course, remove the accessory in question and add it back again. 😀aef7298
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @johannrichard
Perfect and you can close this bug.
Had to remove the item from the homebridge first and then restart it, but I think it's absolutely OK!