Tidied up class definitions on top of x-magic's fork #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow LinkedIn logout (block) to raise exception (so it can be handled in main logic)
- Reformatted the file - Removed the scraper for not-logged-in user (unusable) - Scraping additional information about employment and education
Fixed bug
merge with x-magic
Removed class level properties Streamlined Person and Company __init__() Added super().__initi__() to all classes inheriting class Instituntion in objects.py Updated version to 2.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took x-magic's fork and cleaned up all the classes. This stops subsequent instances of Person having preset features from the first instance created and takes on the streamlining that x-magic has suggested (including removing scrape while not logged in).
Let me know if you like any of it. I have also got a MasterUser class nearly ready to push that extracts all your contacts names and linkedin urls.