Skip to content
This repository has been archived by the owner on Jun 1, 2021. It is now read-only.

Fix documentation #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leandroribeiro
Copy link

Hi Joe,

I found two problems in the documentation.

First, there is one reference to "PlusOnTab" but the correct property is "PlusAsTab".

Second, when using JQuery selector to include and exclude, need put exclude selectors first.

Thats all.

@joelpurra
Copy link
Owner

@leandroribeiro: hmm. What is the problem you see when you put the include before the exclude? Disabling elements should work as expected no matter which order you execute $(selector).plusAsTab(false); with or without false.

From joelpurra/plusastab#disabling-plussing:

Disabling plussing takes precedence over enabling plussing.

Can you please write a test case to show me the bug? I'd prefer a test in the current test framework, but using jsbin or jsfiddle would work as well. See test/basic.js.

Thanks for finding the typo! I'd like to fix it, but since it's in the same pull request as what I am asking above, I cannot merge it until that has been resolved. I would gladly accept a separate pull request fixing only the typo though =)

@leandroribeiro
Copy link
Author

Hi Joel,

When I was testing in IE11 it doesn't works when I put exclude selectors after include selector, but I will make tests for this too.

And after I will create other pull request about the typo.

@joelpurra
Copy link
Owner

@leandroribeiro: I don't have access to IE11, so that would be great! The typo fix would be great as well =)

Thank you for your efforts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants