This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
iOS fixes + cleanup #135
Open
iOS fixes + cleanup #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeferraro I need this in master, can you merge this please? |
|
Thanks for the fixes, working perfectly. |
|
I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplicated
getAllmethod was causing the React Native bridge to fail when it couldn't resolve which target to use.This also cleans up cookie list generation to use the helper that already existed (
createCookieList) and adds (optional) expiration date formatting to it.