Consistently use keyword arguments when defining minor modes

[phikal]

Since Emacs 30 (?) not doing this appears to trigger a warning during byte compilation.

[joaotavora]

Thanks. How old are the Emacsen you've tested this in? It should at least work with Emacs 25.2, hopefully also 24.3. The CI used to test this, but it has been down for some time (volunteers most welcome to convert the Travis CI to GitHub actions CI).

[phikal]

João Távora ***@***.***> writes:

Thanks. How old are the Emacsen you've tested this in? It should at least work with Emacs 25.2, hopefully also 24.3. The CI used to test this, but it has been down for some time

None, because this should be a safe transformation. According to [0] support for keyword arguments has been around since Emacs 21 (so 20+ years). Is there anything specific you are concerned about. I can test anything you need back until 24.3.

(volunteers most welcome to convert the Travis CI to GitHub actions CI).

I have little experience working with CI systems, but Daniel Mendler has added GitHub Action-style CI support to Compat, perhaps you can copy and adjust that to what you need. [0] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4004dde6ea92d9139b67e59c072a9ce52f4ed15c [1] https://github.com/emacs-compat/compat/blob/main/.github/workflows/makefile.yml

…

-- Philip Kaludercic

[joaotavora]

I have little experience working with CI systems, but Daniel Mendler has
added GitHub Action-style CI support to Compat, perhaps you can copy and
adjust that to what you need.

I have it in Eglot as well, so I'ts probably best to copy that. I just need someone to put in the work.

can test anything you need back until 24.3.

In that case please test that the files you've changed compile equally well (or better) before and after your change. For these cosmetic changes you've been proposing it's best to be safe than sorry :)

[phikal]

In that case please test that the files you've changed compile equally well (or better) before and after your change. For these cosmetic changes you've been proposing it's best to be safe than sorry :)

That will take a while. I can confirm there are no issues on Emacs 30. I suspect more people will be finding this issue soon because of the warnings triggered by using the deprecated syntax, perhaps they can confirm it works on other versions of Emacs.

[joaotavora]

SLY's trunk is software used in production in teams of people that I guarantee are using pretty old versions of Emacs, so again I'd rather be safe than sorry.