Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow READ-FROM-MINIBUFFER-IN-EMACS to return an empty string #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daewok
Copy link
Contributor

@daewok daewok commented May 13, 2022

The docstring for READ-FROM-MINIBUFFER-IN-EMACS says that an empty string is
returned when a user enters nothing. Prior to this commit,
SLY-READ-FROM-MINIBUFFER was called in such a way that an empty result wasn't
allowed.

The docstring for READ-FROM-MINIBUFFER-IN-EMACS says that an empty string is
returned when a user enters nothing. Prior to this commit,
SLY-READ-FROM-MINIBUFFER was called in such a way that an empty result wasn't
allowed.
@daewok
Copy link
Contributor Author

daewok commented May 13, 2022

It kind of looks like the t that was already present in the call to sly-read-from-minibuffer may have been intended for the allow-empty optional argument, but instead it's consumed by the hist optional argument.

So I'm unsure if the correct fix is (sly-read-from-minibuffer prompt initial-value t t) (history is not saved) or (sly-read-from-minibuffer prompt initial-value nil t) (history is saved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant