Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use grizzly K8S wrapper library #2

Merged
merged 1 commit into from Mar 18, 2024
Merged

feat: use grizzly K8S wrapper library #2

merged 1 commit into from Mar 18, 2024

Conversation

mikaello
Copy link
Contributor

@mikaello mikaello commented Mar 5, 2024 •
edited

Closing #1

I am not sure if committing the vendor directory is good practice, it generates a very large diff (I did this because it was previously committed).

@mikaello
Copy link
Contributor Author

mikaello commented Mar 5, 2024 •
edited

See PR to remove vendor: #3

If you prefer having vendor committed I am fine with that, just close the PR removing it.

@mikaello mikaello mentioned this pull request Mar 5, 2024
Closed
@joanlopez joanlopez self-requested a review March 18, 2024 14:14
@joanlopez joanlopez merged commit 0c2514b into joanlopez:main Mar 18, 2024
@joanlopez
Copy link
Owner

Merged & deployed, it worked! 🚀

Thanks @mikaello, really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanlopez joanlopez joanlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikaello @joanlopez