drop_artifacts in old_format_output not passed as input variable

[adriangutierrezg]

Dear Johannes,

I realized that the input variable drop_artifacts in the main() function of /combinato/tools/old_format_output (line 91) is not passed on as an actual argument:

Line 91:
def main(fname_data, fname_sorting, sign, outfname, drop_artifacts=False)

Line 101:
joined = man.get_groups_joined()

https://github.com/jniediek/combinato/blob/6973ca113300130c5e8e37830267df5043be03f5/tools/old_format_output.py#LL101C24-L101C24

effectively passing line 101 joined = man.get_groups_joined() with artifacts=True on every call.

A possible fix would be something of the sort:

if drop_artifacts: 
    joined = man.get_groups_joined(artifacts=False)
else:
    joined = man.get_groups_joined(artifacts=True)

am I maybe missing something? What do you think?
Thanks!
Adrian.

[jniediek]

Hi Adrian,
You are right, and I think your fix is exactly the right one. Would you be able to create a pull request with the fix?
Cheers
Johannes

[jniediek]

That's fixed now, right?

[adriangutierrezg]

It is, thanks!