New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated volume normalization #706
Conversation
…s on unsupported platforms
- since server now sends an actual gain, it isn't a probelm if the gain were mistakenly 0
@Komodo5197 will a downloads repair be enough to update the |
It could be, but does need some tweaks. I wanted to reduce unneeded database writes, so the metadata only updates if the function BaseItemDto.mostlyEqual returns false. You can add a comparison of the relevant attributes there and it should work. |
…treams` are missing
@Komodo5197 if you don't have anything else, I'll go ahead an merge this :) |
The downloads change looks good, I haven’t payed too much attention to the other code. I’ll note with this and the lyrics PR we’re up to ~6 feature chips, and it would be nice to be able to disable some in settings to avoid scrolling on small screens. That’s only slightly related to this though. |
Okay. Yeah customizing feature chips is definitely planned. I'd like to move away from the generic list of switches as settings, to a more tailor-made customization that fits whatever is customized, along with a preview. For the feature chips I'd like a way to show/hide or add/remove chips, and reorder them. All of this should be reflected in the preview, but the preview shouldn't be interactive. All customization should use separate controls. I'll see if I can get any work done on this in the coming weeks, including an initial mockup. But for now, a bit of overflow is fine. The complaints might motivate me to work on it sooner rather than later xD |
Adapts volume normalization / replay gain based on the upcoming changes in jellyfin/jellyfin#11457
Removes outdated settings and shows normalization gain as a feature chip