Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated volume normalization #706

Merged
merged 7 commits into from May 2, 2024

Conversation

Chaphasilor
Copy link
Collaborator

Adapts volume normalization / replay gain based on the upcoming changes in jellyfin/jellyfin#11457

Removes outdated settings and shows normalization gain as a feature chip

@Chaphasilor Chaphasilor self-assigned this Apr 29, 2024
@Chaphasilor Chaphasilor marked this pull request as ready for review May 1, 2024 21:12
@Chaphasilor
Copy link
Collaborator Author

@Komodo5197 will a downloads repair be enough to update the BaseItemDto metdata for offline mode when people upgrade to 10.9? Or do we need to add a migration for that?

@Komodo5197
Copy link

It could be, but does need some tweaks. I wanted to reduce unneeded database writes, so the metadata only updates if the function BaseItemDto.mostlyEqual returns false. You can add a comparison of the relevant attributes there and it should work.

@Chaphasilor
Copy link
Collaborator Author

@Komodo5197 if you don't have anything else, I'll go ahead an merge this :)

@Komodo5197
Copy link

The downloads change looks good, I haven’t payed too much attention to the other code. I’ll note with this and the lyrics PR we’re up to ~6 feature chips, and it would be nice to be able to disable some in settings to avoid scrolling on small screens. That’s only slightly related to this though.

@Chaphasilor
Copy link
Collaborator Author

Okay. Yeah customizing feature chips is definitely planned. I'd like to move away from the generic list of switches as settings, to a more tailor-made customization that fits whatever is customized, along with a preview.
So in the case of the feature chips, we'd show a preview with some sample data, and the preview would be the same size as the chips will end up being on the player screen. Maybe related settings (e.g. player screen) could share a single preview.

For the feature chips I'd like a way to show/hide or add/remove chips, and reorder them. All of this should be reflected in the preview, but the preview shouldn't be interactive. All customization should use separate controls.

I'll see if I can get any work done on this in the coming weeks, including an initial mockup.

But for now, a bit of overflow is fine. The complaints might motivate me to work on it sooner rather than later xD

@Chaphasilor Chaphasilor merged commit 10d9a0e into redesign May 2, 2024
4 checks passed
@Chaphasilor Chaphasilor deleted the redesign-updated-volume-normalization branch May 2, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants