✨ Upgrade chopper and aggregate chopper logs to single entry #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
force-pushed
the
log-aggregation
branch
2 times, most recently
from
97612e4
to
40ca514
Compare
Maxr1998
force-pushed
the
log-aggregation
branch
from
40ca514
to
95c9dcf
Compare
|
Thanks, I'll just merge it now and put out any fires that come up from the upgrade :) |
|
Alright, thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the log screen has a lot of short or empty entries from chopper, aggregating the chopper logs per request and response fixes this. However, this requires the latest chopper version (since the required changes were also contributed by myself), and that required a few more updates. Preferably, you'd make those dependency updates yourself and afterward I rebase this PR.