Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize location lookup, avoid repeated config reads #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize location lookup, avoid repeated config reads #372

wants to merge 1 commit into from

Conversation

adamcandy
Copy link
Contributor

This caches the false states of 'prefer_english_names', which I expect is what was intended.
Fixes #371 (Geolocation examines config.ini for every new lookup).

@coveralls
Copy link

coveralls commented Apr 20, 2020 •
edited

Coverage Status

Coverage decreased (-0.2%) to 90.877% when pulling aa02369 on adamcandy:prefer-english-names-optimize into 8e95b96 on jmathai:master.

@jmathai
Copy link
Owner

jmathai commented Apr 22, 2020

This looks good. Can you cherry pick the commits from #370 into this branch so we can combine them into a single PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geolocation examines config.ini for every new lookup
3 participants
@adamcandy @coveralls @jmathai