Do not update fields that haven't changed #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which at this point means the primary key fields. In the future, one may have a logic to detect actual changes and create records where the Pojo fields that haven't changed are not set. This may be very useful to support MySQL/MariaDB `TIMESTAMP` fields with an `ON UPDATE CURRENT_TIMESTAMP()` feature, which are currently being overwritten by the old value in the POJO and there for are broken with vertx-jooq.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently "unchanged" fields are just the primary key fields that get reset a few LoCs above.
In the future, one may have a logic to detect actual changes and create records where the POJO fields that haven't changed are correctly reset as well.
This may be very useful to support MySQL/MariaDB
TIMESTAMPfields with anON UPDATE CURRENT_TIMESTAMP()feature, which are currently being overwritten by the old value in the POJO and there for are broken with vertx-jooq.