fix(#391): timezones #404
Closed
fix(#391): timezones #404
+91
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrule time base is UTC whereas Luxon requires dates in local format to calculate the correct time offset. New tests where introduced to prove correct behaviour in different system timezones. Run those with `npm run test:tz`
bobymicroby
approved these changes
Jun 15, 2020
|
Any chance to get this merged in? We've been using the branch and it seemed to fix all our timezone issues. |
|
@greenreign May be still actual. I also needed that fix so I published this package to NPM registry with this PR merged |
davidgoli
requested changes
Oct 31, 2021
| "test:tz": "npm run test:tz1 && npm run test:tz2 && npm run test:tz3", | ||
| "test:tz1": "TZ=Asia/Tokyo npm t", | ||
| "test:tz2": "TZ=Europe/Madrid npm t", | ||
| "test:tz3": "TZ=America/Chicago npm t" |
There was a problem hiding this comment.
This project uses yarn, please change these to reference yarn instead of npm
| @@ -37,8 +37,9 @@ describe('rezonedDate', () => { | |||
| const currentLocalDate = DateTime.local(2000, 2, 6, 1, 0, 0) | |||
| setMockDate(currentLocalDate.toJSDate()) | |||
|
|
|||
| const d = DateTime.fromISO('20101005T110000').toJSDate() | |||
| const d = DateTime.fromISO('20101005T110000Z').toJSDate() | |||
There was a problem hiding this comment.
The purpose of this test is not to test the ability to use UTC (which already works). It's to test conversion from local time into the expected timezone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #391
rrule time base is UTC whereas Luxon requires dates in local format to
calculate the correct time offset.
New tests where introduced to prove correct behavior in different
system timezones. Run those with
npm run test:tz