Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing artifact resolver for the bom-resolution #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balrok
Copy link
Contributor

@balrok balrok commented May 8, 2024

This issue was introduced with PR #287.
When calling the pomReader, the resolver was not always set and caused several (non-critical) exceptions in the log. Like:

Failed to retrieve artifacts for [group:com.google.code.gson, name:gson-parent, version:2.10.1, ext:pom]
java.lang.NullPointerException: Cannot invoke method resolveArtifacts() on null object


Failed to retrieve artifacts for [group:com.fasterxml.jackson, name:jackson-parent, version:2.16, ext:pom]
java.lang.NullPointerException: Cannot invoke method resolveArtifacts() on null object

Failed to retrieve artifacts for [group:software.amazon.awssdk, name:aws-sdk-java-pom, version:2.23.15, ext:pom]
java.lang.NullPointerException: Cannot invoke method resolveArtifacts() on null object

Those come frome the parents of the resolved bom-poms. This was due to having no resolver initialized.

After the change, it could resolved jackson-parent in the test and also added its license to the result. That's why the test changed slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant