feat: move jwt to URL hash from search parameters

[aaronkvanmeerten]

This updates the external API to send the JWT both as a URL hash parameter as well as a query string for backwards compatibility. The JWT parsing function now prefers the hash value over the query string value.

[damencho]

Can you add a comment at the place we want to drop down the road? with a TODO. Thanks

[hristoterezov]

Suggested change

	const jwt = parseURLParams(url, true, 'hash').jwt;
	// TODO: eventually remove the search param and only pull from the hash
	// @ts-ignore
	return jwt ? jwt : parseURLParams(url, true, 'search').jwt;
	return parseURLParams(url, true, 'hash').jwt;

[saghul]

Please @aaronkvanmeerten respect the repo commit convention.

I know not all repos have the same.

[damencho]

What do you mean?

[saghul]

feat(thing) description

[damencho]

Well, honestly, that is also new to me. I remember when we added that in the guideline and it was saying feat, fix and lang. Now I see it has changed and I do not see it mentioning the lang prefix.

[damencho]

This was changed a year and a half ago jitsi/handbook@8fc45b8
I was not aware of this change and that change also dropped the lang: notation and I do not remember discussion with the team about it, but maybe I missed that.

[saghul]

FTR, we discusses offline and will continue doing so.