add --syncstats option #760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--syncstats` option is to support general per-dataset instrumentation of the syncoid process, and allows you to specify a file path to dump per-dataset stats to. The specified file will contain json with stats for each dataset that is considered. The original use case driving this change is to parse the output file after the sync is complete, and send the data to your metric tracking system/TSDB of choice. For this commit, the only stat currently added is the sync duration (`sync_duration_s`). However, the code/output has been set up to make it easy to add more per-dataset stats in the future. For example, `delta_bytes` (the size of the incremental delta in bytes) would be another nice stat to add later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--syncstatsoption is to support general per-dataset instrumentation of the syncoid process, and allows you to specify a file path to dump per-dataset stats to. The specified file will contain json with stats for each dataset that is considered.The original use case driving this change is to parse the output file after the sync is complete, and send the data to your metric tracking system/TSDB of choice.
For this commit, the only stat currently added is the sync duration (
sync_duration_s). However, the code/output has been set up to make it easy to add more per-dataset stats in the future. For example,delta_bytes(the size of the incremental delta in bytes) would be another nice stat to add later.