Fix wrong relative paths in subninjas and fix tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
force-pushed
the
master
branch
7 times, most recently
from
785742a
to
ad5ce2d
Compare
Jarod42
reviewed
Apr 24, 2023
| @@ -133,7 +133,8 @@ def exe(self, path): | |||
| if os.path.exists(path): | |||
| current_cwd = os.getcwd() | |||
| os.chdir(self.build_dir) | |||
| subprocess.check_call([os.path.relpath(path, self.build_dir)]) | |||
| executable = os.path.relpath(path, self.build_dir) | |||
| subprocess.check_call([executable], env={'LD_LIBRARY_PATH': os.path.dirname(executable)}) | |||
There was a problem hiding this comment.
Thanks, Applied that part (+ DYLD_LIBRARY_PATH for macos).
Jarod42
reviewed
Apr 24, 2023
| @@ -29,7 +29,7 @@ project "ninjatestprj_app" | |||
| defines {"NDEBUG"} | |||
| optimize "On" | |||
|
|
|||
| project "ninjatestprj_lib test1" | |||
| project "ninjatestprj_lib_test1" | |||
There was a problem hiding this comment.
Might be seen as typo, but handling of space in project in now supported by this module.
Jarod42
force-pushed
the
master
branch
10 times, most recently
from
a2461ee
to
1738d84
Compare
|
Fixed by 5729cbe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When projects have a different location than the workspace, it breaks ninja as the relative paths in the subninjas are relative to the subninja and not the build directory (ninja-build/ninja#977).
Also, some tests were broken (at least on Linux).
If you prefer to split it to 2 pull requests, let me know.
Not tested on non-Linux setups.