Add optional context_object_name to TemplateColumn and make extra_context optionally callable
#931
Conversation
…a_context` optionally callable fixes: #928
jieter
force-pushed
the
feature/improve-template-column
branch
from
cba0965
to
7691bf3
Compare
jieter
force-pushed
the
feature/improve-template-column
branch
from
475dd3d
to
fe78309
Compare
| @@ -14,7 +15,9 @@ class TemplateColumn(Column): | |||
| Arguments: | |||
| template_code (str): template code to render | |||
| template_name (str): name of the template to render | |||
| extra_context (dict): optional extra template context | |||
| context_object_name (str): name of the context variable to pas the record in, defaults to "record". | |||
There was a problem hiding this comment.
| context_object_name (str): name of the context variable to pas the record in, defaults to "record". | |
| context_object_name (str): name of the context variable to pass the record in, defaults to "record". |
There was a problem hiding this comment.
"to pass the record in" klinkt gek. Wellicht "name of the context variable that represents the record, defaults to "record". ?
There was a problem hiding this comment.
| context_object_name (str): name of the context variable to pas the record in, defaults to "record". | |
| context_object_name (str): name of the context variable that represents the record, defaults to "record". |
| extra_context (dict): optional extra template context. If a callable is passed, it will be called with | ||
| optional record, table, value, bound_column arguments. |
There was a problem hiding this comment.
| extra_context (dict): optional extra template context. If a callable is passed, it will be called with | |
| optional record, table, value, bound_column arguments. | |
| extra_context (dict): optional extra template context. Any callables passed will be called with the following | |
| optional arguments: record, table, value, and bound_column. |
There was a problem hiding this comment.
kan je meer dan 1 callable meegeven in de dict?
There was a problem hiding this comment.
gegeven mijn verwarring over extra_context hieronder kunnen we niet zeggen:
extra_context: accepts dict or callable. If a called is passed it will be called with the following optional arguments: record, ...
| "value": value, | ||
| "row_counter": kwargs["bound_row"].row_counter, | ||
| } | ||
| additional_context.update(self.extra_context) | ||
|
|
||
| extra_context = self.extra_context |
There was a problem hiding this comment.
ik vind "additional" en "extra" content wel dubbelop? Waar is additional voor en waar is extra voor? Kunnen we de namen niet wat aanpassen in termen van waar ze voor dienen?
| additional_context.update(self.extra_context) | ||
|
|
||
| extra_context = self.extra_context | ||
| if callable(extra_context): |
There was a problem hiding this comment.
ik had uit de docstring begrepen dat extra_context een dict was - dus dan zou ik de callable meegeven in een dict ... maar blijkbaar moet je een callable toewijzen aan extra_context? Dus voor mij is de docstring van verwarrend
There was a problem hiding this comment.
You should return a callable returning a dict.
| table = Table([{"name": "Bob"}]) | ||
| self.assertEqual(list(table.as_values()), [["Name"], ["Bob"]]) | ||
|
|
||
| def test_extra_context_callable(self): |
There was a problem hiding this comment.
test voor extra context dict was er al toch?
| def test_extra_context_callable(self): | ||
| class Table(tables.Table): | ||
| size = tables.TemplateColumn( | ||
| "{{ size }}", extra_context=lambda record: {"size": record["clothes"]["size"]} |
There was a problem hiding this comment.
ik zou het wel beter vinden als er meer optional arguments getest zouden worden? table / value / bound column - ik zie niet goed hoe dat hier terug komt.
fixes: #928