Separate table class definition and instantiation in MultiTableMixin #876 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h a separation between table class definition and instantiation.
… Add new test for MultiTableMixin.get_tables_classes
Re do the change to allow MultiTableClasses.get_tablers_classes, but this time with f-string formatting.
Make the test for get_tables_classes() use a list of tables. Test will probably fail
Update formatting, fix test regressions
…h requested cahnges.
jieter
changed the title
jieter
reviewed
Feb 1, 2023
| if len(data) != len(tables): | ||
| klass = type(self).__name__ | ||
| raise ImproperlyConfigured(f"len({klass}.tables_data) != len({klass}.tables)") | ||
| return list(Table(data[i], **kwargs) for i, Table in enumerate(tables)) |
There was a problem hiding this comment.
How would one specify the kwargs passed through here?
| html = response.rendered_content | ||
| self.assertIn("<h1>Multiple tables using MultiTableMixin</h1>", html) | ||
|
|
||
| def test_with_empty_get_tables_clases_list(self): |
There was a problem hiding this comment.
Suggested change
| def test_with_empty_get_tables_clases_list(self): | |
| def test_with_empty_get_tables_classes_list(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally closed the earlier pull request, but this doe the same but against the current master (sorry!)
This adds a
MultiTableMixin.get_tables_classes()that returns an iterable of table classes to allow this to be customised at run time without overriding the wholeget_tables()method.From previous comments:
MultiTableMixin.get_tables_classesto check that the rendered output does have two tables - thus checking that the get_tables_classes was used.fixes: #875