Feature: cuboids-from-id #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movestill
requested changes
Mar 26, 2021
intern/service/boss/baseversion.py
Outdated
| if url_prefix is None or url_prefix == '': | ||
| raise RuntimeError('url_prefix required.') | ||
|
|
||
| url = (url_prefix + '/' + self.version + '/cuboidsfromid/' + |
There was a problem hiding this comment.
Now that we're only supporting modern Python versions 🥳, you could switch to an f string which I think would look nicer.
| """Get corners for cuboids that belong to a specific ID. | ||
|
|
||
| All returned corners are cuboid aligned. |
There was a problem hiding this comment.
I think we should say which corner is returned. IIRC, it's the corner closest to the origin?
movestill
reviewed
May 16, 2021
intern/remote/remote.py
Outdated
|
|
||
| Returns: | ||
| (dict): {'cuboids': [[512, 512, 64], [0, 512, 32], [512, 512, 32], [0, 512, 48]]} |
There was a problem hiding this comment.
Looks good, just update the returns comment to match the new comments for get_cuboids_from_id().
|
@dxenes1 can we merge this? |
Still waiting for the changes to be merged in BossDB backend, but after that it should be good |
|
Updated docs and published this PR as ready for review (and merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds remote function for the
cuboidsfromidapi in bossDB. It is now possible to get a list of cuboids that belong to a specific annotation ID. Remote syntax is as follows: