Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds some suggestions #88

Merged
merged 1 commit into from Sep 7, 2023
Merged

adds some suggestions #88

merged 1 commit into from Sep 7, 2023

Conversation

Nowosad
Copy link
Contributor

@Nowosad Nowosad commented Aug 29, 2023

OpenGeoHub summer school 2023 work:

  1. Fixes a few typos
  2. Updates bib style (new CRAN requirement)
  3. Hides .devcontainer
  4. Hides one test (that requires API)

Also @jhollist -- I would suggest renumbering the version to, e.g., 0.99 or just completely switch to SpatRaster and use 1.0.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.40% ⚠️

Comparison is base (2849667) 84.07% compared to head (e374425) 74.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   84.07%   74.67%   -9.40%     
==========================================
  Files           4        4              
  Lines         383      383              
==========================================
- Hits          322      286      -36     
- Misses         61       97      +36     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@jhollist
Copy link
Owner

jhollist commented Sep 7, 2023

@Nowosad Thanks for this and sorry for delay in responding. Just got back from vacation this week and have finally dug out of most of the pile. I'll take a look at this today/tomorrow. I also really like the versioning suggestion.

@jhollist jhollist merged commit f39dc33 into jhollist:main Sep 7, 2023
7 of 9 checks passed
@Nowosad
Copy link
Contributor Author

Nowosad commented Sep 7, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants