Fix jhiAlert and jhiAlertErrors components #3045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #3043 I realized that I've refactored wrongly the alert and alert-error directives into components.
In directives, second parameter in
.directive('jhiAlertError', jhiAlertError)
was a function, in components it has to be a variable. So I fixed it and turned functions into variables.I followed this issue to stay consistent with Johnpapa's style.