jgrss/store time series #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to try to take a look at this. |
mmann1123
reviewed
May 6, 2024
|
|
||
| DF = gpd.GeoDataFrame(geometry=[shape(geojson)], crs=4326) |
There was a problem hiding this comment.
should be updated to shape(search_geojson) I think.
mmann1123
reviewed
May 6, 2024
| @@ -28,15 +35,47 @@ | |||
| ], | |||
| } | |||
|
|
|||
| EPSG = 8857 | |||
There was a problem hiding this comment.
its failing without this line
mmann1123
approved these changes
May 6, 2024
jgrss
commented
May 6, 2024
| ) | ||
|
|
||
| if hasattr(self.data, "_FillValue"): | ||
| nodata = self.data.attrs["_FillValue"] |
There was a problem hiding this comment.
This is no longer a user argument.
jgrss
commented
May 6, 2024
| if self.scatter is None: | ||
| band_count = self.data.gw.nbands | ||
| else: | ||
| if self.scatter == 'band': |
There was a problem hiding this comment.
what is file scattering?
jgrss
commented
May 6, 2024
| memory_limit="1GB", | ||
| ) as cluster: | ||
| with Client(cluster) as client: | ||
| time_mean.gw.save( |
There was a problem hiding this comment.
Here is the test using a client.
jgrss
commented
May 6, 2024
| client (Optional[Client object]): A ``dask.distributed.Client`` client object to persist data. | ||
| Default is None. | ||
| compute (Optinoal[bool]): Whether to compute and write to ``filename``. Otherwise, return | ||
| the ``dask`` task graph. If ``True``, compute and write to ``filename``. If ``False``, | ||
| return the ``dask`` task graph. Default is ``True``. | ||
| tags (Optional[dict]): Metadata tags to write to file. Default is None. | ||
| compress (Optional[str]): The file compression type. Default is 'none', or no compression. | ||
|
|
||
| .. note:: |
jgrss
commented
May 6, 2024
| def test_client_save(self): | ||
|
|
||
| with LocalCluster( | ||
| processes=False, |
There was a problem hiding this comment.
Necessary to write to compressed file.
jgrss
commented
May 6, 2024
| filename=out_path, | ||
| overwrite=True, | ||
| tags={"TEST_METADATA": "TEST_VALUE"}, | ||
| compress="lzw", |
|
I merged this into #319. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR changing?
save()