Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable installation as a gem-based theme #166

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

tnlx
Copy link

@tnlx tnlx commented Apr 29, 2024

Hi!

Thank you for the clean and very balanced theme!

As title,

  • I'm moving stylesheets to /assets because /css is not a recognized directory for gem-based theme.

With gem-based themes, some of the site’s directories (such as the assets, _data, _layouts, _includes, and _sass directories) are stored in the theme’s gem, hidden from your immediate view. Yet all of the necessary directories will be read and processed during Jekyll’s build process.

https://jekyllrb.com/docs/themes/#understanding-gem-based-themes

  • Move the footer text to _config.yml to make it customizable when the theme is installed this way.

Possible usage after merging

# Gemfile
gem 'resume-template', git: 'git@github.com:jglovier/resume-template', ref: '...'
#https://bundler.io/guides/git.html
# _config.yml
theme: resume-template

resume_footer:
  - Paragraph 1
  - Paragraph 2

- Move css/main.scss to assets/css
- Make footer text customizable
@tnlx tnlx changed the title Move stylesheets to /assets to enable installation as a gem-based theme Enable installation as a gem-based theme May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant