Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change gammatone requirement to Gammatone #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quancs
Copy link
Contributor

@quancs quancs commented Jun 12, 2023

Hello, Torchmetrics requires SRMRpy for validating its implementations. However, SRMRpy install Gammatone by https://github.com/detly/gammatone/archive/master.zip#egg=Gammatone which will be skipped for pypi. So, this pull request change it to git+https://github.com/detly/gammatone, which will not affect the installtion of SRMRpy, but will make the requirements in Torchmetrics works. see the discussion here Lightning-AI/torchmetrics#1792 (comment)

@Borda
Copy link

Borda commented Jun 29, 2023

On this note, gammatone shall be released on PyPI otherwise, this won't be picked by PR as they do not allow packages outside its registry so no URL or git references to a package 🐰

@quancs
Copy link
Contributor Author

quancs commented Jun 29, 2023

On this note, gammatone shall be released on PyPI otherwise, this won't be picked by PR as they do not allow packages outside its registry so no URL or git references to a package 🐰

The response from the author of gammatone:
detly/gammatone#16 (comment)

setup.py Outdated Show resolved Hide resolved
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@quancs quancs changed the title change gammatone to gammatone @ git+https://github.com/detly/gammatone change gammatone requirement to Gammatone Jun 30, 2023
@jfsantos
Copy link
Owner

Apologies for the delay, I didn't understand from the response from the author of gammatone and subsequent responses if Gammatone was published to PyPI or not. Can you confirm if this is still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants