Fixed issue #167 and issue #165 #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the test file successfully creates the pie chart without overlapping labels.
| @@ -42,6 +42,8 @@ | |||
| * Represents a date using an integer, in a similar fashion to the | |||
| * implementation in Microsoft Excel. The range of dates supported is | |||
| * 1-Jan-1900 to 31-Dec-9999. | |||
| * (This year limit is removed to support years | |||
| * earlier than 1990, which is currently supported in Microsoft Excel.) | |||
There was a problem hiding this comment.
Suggestion: Just remove the last sentence (starting on line 43 and ending on 44) - then no need for adding lines 45 and 46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #167 was fixed by automatically calculating the percentage of each category in a pie chart. For categories with less than 5% weight, their labels are created outside the pie chat to prevent overlapping.
Issue #165 was fixed by modifying the year limit to support years earlier than 1990, which is currently supported in Microsoft Excel.