Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement export & import #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kaelinator
Copy link

Addresses #19

@Kaelinator
Copy link
Author

Usage:
jevakallio.vscode-hacker-typer.exportMacro will bring up a quick pick for the user to select which macro to export, followed by a file selection window for the destination.

jevakallio.vscode-hacker-typer.exportMacro opens a file selection window for the user to select a file to import. The name of the macro is the file name without the extension.

The macros are saved as JSON data.

Copy link

@RRicardotj RRicardotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks awesome. Actually I thought this was an original feature when I realized it's not implemented in the current version.

But why is the package.json changed? Did you install or remove any dependency?

@Kaelinator
Copy link
Author

This feature looks awesome. Actually I thought this was an original feature when I realized it's not implemented in the current version.

But why is the package.json changed? Did you install or remove any dependency?

Are you referring to the changes made in 0f035a2? My guess is that I was having trouble testing or something. I know in a lot of my personal projects, the package-lock.json likes to give me issues. I don't think I deleted or added anything to package.json, if that's what your concerned with.

@RRicardotj
Copy link

This feature looks awesome. Actually I thought this was an original feature when I realized it's not implemented in the current version.
But why is the package.json changed? Did you install or remove any dependency?

Are you referring to the changes made in 0f035a2? My guess is that I was having trouble testing or something. I know in a lot of my personal projects, the package-lock.json likes to give me issues. I don't think I deleted or added anything to package.json, if that's what your concerned with.

Yeah, I meant the package-lock-json. OK, I got what you mean. 👍

Copy link

@RRicardotj RRicardotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

TiagoDanin added a commit to TiagoDanin/VSCode-Hacker-Typer that referenced this pull request Sep 18, 2022
@wcandillon
Copy link

I played with this PR and it works great! I would love to see it merged/publish (of course we can use the extension from the PR directly but just of convenience).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants