Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Update kube-state-metrics to the latest version #751

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MattiasGees
Copy link
Member

Signed-off-by: Mattias Gees mattias.gees@gmail.com

What this PR does / why we need it:
This updates kube-state-metrics to the latest version and it fixes some RBAC issues we had with 1.4. With 1.4 we got errors in the logs

E0221 10:13:53.230160       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope
E0221 10:13:54.238317       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "secrets" in API group "" at the cluster scope
E0221 10:13:54.239928       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope
E0221 10:13:55.239963       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "secrets" in API group "" at the cluster scope
E0221 10:13:55.241302       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope
E0221 10:13:56.241796       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "secrets" in API group "" at the cluster scope
E0221 10:13:56.242690       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Update kube-state-metrics to 1.5.0

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MattiasGees
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: simonswine

If they are not already assigned, you can assign the PR to them by writing /assign @simonswine in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the area/puppet Indicates a PR is affecting Puppet manifests label Feb 21, 2019
@MattiasGees
Copy link
Member Author

/unassign
/assign @simonswine

@simonswine
Copy link
Contributor

Can you have a look at this:
https://twitter.com/opsgoodness/status/1098266699382620160

Don't want to get into that trouble with the update. The performance fixes seemed to have happened with 1.5.0

/assign @MattiasGees
/unassign

MattiasGees and others added 2 commits June 4, 2019 11:25
Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
Signed-off-by: Christian Simon <simon@swine.de>
@jetstack-bot
Copy link
Collaborator

@MattiasGees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-15-centos b3de0f0 link /test puppet-tarmak-acceptance-centos v1.15

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/puppet Indicates a PR is affecting Puppet manifests dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants