Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Use machine API types #663

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Use machine API types #663

wants to merge 14 commits into from

Conversation

JoshVanL
Copy link
Contributor

What this PR does / why we need it:
This PR implements the Machine API types taken from the Kubernetes Cluster API project.
This introduces MachineDeployments and MachineSets as well as Machine, essentially renamed from Instances.
Two new controllers are added to the API server that manage the behavior of Machine deployments and sets.

Every instance pool now has a corresponding deployment, and consequently a set, created to manage the machines in that pool.

This PR helps to implement ground work to further extend wing features such as puppet dry runs.

NOTE: wing-dev-mode must be run with this branch since wing and it's types have been heavily modified.

Change wing API types to use ones similar to Kubernetes Cluster API

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/terraform Indicates a PR is affecting Terraform configuration kind/documentation Categorizes issue or PR as related to documentation. labels Dec 17, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: joshvanl

If they are not already assigned, you can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoshVanL
Copy link
Contributor Author

Should be ready for a first round of reviews
/assign @simonswine

@JoshVanL
Copy link
Contributor Author

/test verify docs

@JoshVanL
Copy link
Contributor Author

/test verify quick

@JoshVanL
Copy link
Contributor Author

/test verify docs

1 similar comment
@JoshVanL
Copy link
Contributor Author

/test verify docs

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2018
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2019
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 2, 2019

/test verify quick

@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 3, 2019

/unassign @simonswine
/assign

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Jan 3, 2019
@jetstack-bot
Copy link
Collaborator

@JoshVanL: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2019
@simonswine
Copy link
Contributor

/hold

I would not like to include this 0.6 release

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2019
@simonswine simonswine added this to the v0.7 milestone Jan 15, 2019
@jetstack-bot
Copy link
Collaborator

@JoshVanL: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos 8222615 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/terraform Indicates a PR is affecting Terraform configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants