Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adds cluster images destroy #601

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds cluster images destroy #601

wants to merge 3 commits into from

Conversation

JoshVanL
Copy link
Contributor

fixes #600

Add `cluster images destroy [image ids]

/assign @MattiasGees

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2018
@MattiasGees
Copy link
Member

Nice, all good

/lgtm
/approve
/unassign @simonswine
/assign

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MattiasGees
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: joshvanl

If they are not already assigned, you can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MattiasGees
Copy link
Member

whoops
/unassign
/assign @simonswine

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2018
@simonswine simonswine assigned JoshVanL and unassigned simonswine Nov 1, 2018
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2018
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Nov 1, 2018

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Nov 1, 2018
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2018
@MattiasGees
Copy link
Member

/lgtm

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 6, 2018
@jetstack-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@jetstack-bot jetstack-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 9, 2018
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2018
@JoshVanL
Adds cluster images destroy
ba6d04b 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Includes --all flag to cluster images destroy
ff74905 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Updates cmd call with flags
4fb4857 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2018
@jetstack-bot
Copy link
Collaborator

@JoshVanL: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2018
@jetstack-bot
Copy link
Collaborator

@JoshVanL: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos 4fb4857 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@charlieegan3 charlieegan3 removed their request for review February 9, 2021 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@simonswine simonswine

@MattiasGees MattiasGees

Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cluster image destroy
4 participants
@JoshVanL @MattiasGees @jetstack-bot @simonswine