Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Change threshold to greater than or equal to #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dippynark
Copy link
Contributor

What this PR does / why we need it: The StatusCheckFailed_System is a binary value so we must check for when the metric equals one

Fix autorecovery threshold for cloudwatch alarms

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 10, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dippynark

If they are not already assigned, you can assign the PR to them by writing /assign @dippynark in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2018
@dippynark
Copy link
Contributor Author

/assign @simonswine

Signed-off-by: Luke Addison <luke.addison@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 10, 2018
@simonswine
Copy link
Contributor

/assign @dippynark

A bit more background: how have you discovered this?.

The UI shows it somehow like that: StatusCheckFailed_System > 1 for 2 datapoints within 2 minutes

I might have understood it. The sum of 2 datapoints needs to be > 1

@dippynark
Copy link
Contributor Author

dippynark commented Sep 10, 2018

@simonswine these blog posts https://aws.amazon.com/blogs/aws/new-auto-recovery-for-amazon-ec2/ and https://aws.amazon.com/blogs/aws/ec2-instance-status-metrics/

Not sure where you are seeing that but it may be grouping them over certain periods. The metric we are setting up is using the minimum so it'd give different results

@jetstack-bot
Copy link
Collaborator

@dippynark: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos 4286ee0 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@charlieegan3 charlieegan3 removed their request for review February 9, 2021 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants