Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adds flag to use own AWS key pair #315

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JoshVanL
Copy link
Contributor

What this PR does / why we need it:
Adds a flag to use an existing key pair in AWS.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #312

Release note:

NONE

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2018
@jetstack-bot jetstack-bot requested a review from wallrj June 18, 2018 20:56
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dippynark

Assign the PR to them by writing /assign @dippynark in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoshVanL JoshVanL changed the title WIP: Adds flag to use own AWS key pair Adds flag to use own AWS key pair Jun 20, 2018
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2018
@JoshVanL
Copy link
Contributor Author

/cc @dippynark

@JoshVanL
Copy link
Contributor Author

/assign @dippynark

@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jul 9, 2018

/assign @simonswine

@simonswine
Copy link
Contributor

I think this should be a configuration option in the tarmak.yaml for the aws provider (and should have the option to be overriden in AWS specific sections of environment,clusters or instancePools)

/unassign
/assign @JoshVanL

@jetstack-bot
Copy link
Collaborator

@JoshVanL: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2018
@jetstack-bot
Copy link
Collaborator

@JoshVanL: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos 41657c3 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow instance SSH key to be referenced as existing key pair name
4 participants