Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Run kube services under system slice #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dippynark
Copy link
Contributor

What this PR does / why we need it: We want the option (enabled by default) to run the kube services under /system.slice

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #297

Run kubelet under /system.slice so that system and kube services get priority over eachother's spare resource if there is resource contention

@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 8, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: simonswine

Assign the PR to them by writing /assign @simonswine in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2018
@dippynark dippynark force-pushed the 297-run-kube-services-under-system-slice branch 9 times, most recently from d811cad to 96652ca Compare June 8, 2018 19:28
@dippynark dippynark force-pushed the 297-run-kube-services-under-system-slice branch from 96652ca to 2749415 Compare June 8, 2018 19:42
@dippynark
Copy link
Contributor Author

/test puppet-tarmak-acceptance-centos v1.10

@simonswine simonswine added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 11, 2018
@dippynark
Copy link
Contributor Author

/assign @simonswine

@jetstack-bot
Copy link
Collaborator

@dippynark: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2018
@jetstack-bot
Copy link
Collaborator

@dippynark: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos 2749415 link /test puppet-tarmak-acceptance-centos v1.14
tarmak-puppet-module-tarmak-acceptance-1-15-centos 2749415 link /test puppet-tarmak-acceptance-centos v1.15
tarmak-puppet-module-tarmak-acceptance-1-13-ubuntu 2749415 link /test puppet-tarmak-acceptance-ubuntu v1.13

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@charlieegan3 charlieegan3 removed their request for review February 9, 2021 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run kube services on the node under /system.slice
3 participants