Add DebugDirectory directory entry type #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrogb
reviewed
Jun 9, 2017
|
|
||
| let rsds_offset: RVA<DebugDirectory> = start_address; | ||
| let rsds_debug_entry: &DebugDirectory = SQLITE_X86_PE.ref_at(rsds_offset).unwrap(); | ||
| assert_eq!(rsds_debug_entry.debug_type, 2); |
jethrogb
reviewed
Jun 9, 2017
| @@ -43,6 +43,35 @@ fn list_sections() { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn rsds_debug_directory() { | |||
There was a problem hiding this comment.
Can you check add tests for the 64-bit image as well?
|
Neat! |
jethrogb
reviewed
Jun 9, 2017
| @@ -85,6 +85,7 @@ macro_rules! directory_entry( | |||
|
|
|||
| directory_entry!(ExportTable = RVA<ExportDirectory>); | |||
| directory_entry!(BaseRelocationTable = RVA<RelocationBlock>); | |||
| directory_entry!(Debug = RVA<DebugDirectory>); | |||
There was a problem hiding this comment.
I think RVA<[DebugDirectory]> would be more appropriate. Can you also add pub fn get_debug_directories(&self) -> Result<&'data [DebugDirectory]> to impl Pe?
There was a problem hiding this comment.
Could you clarify on RVA<[DebugDirectory]>, [DebugDirectory] is not RefSafe so wouldn't be able to implement the Directory trait.
There was a problem hiding this comment.
I think that's actually too strict a limitation and the RefSafe bound can be moved to Directory::Type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.