Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function callback when back button is pressed (#149) #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alunparanggi
Copy link

@alunparanggi alunparanggi commented Jan 20, 2022

Connection with issue(s)

Resolve issue #149

Testing and Review Notes

how to test :

  1. open app
  2. home tab will be shown
  3. move to other tab (Vehicles, Upcoming, or others)
  4. press back button (android device)
  5. screen will move to home tab

Screenshots or Videos

spacex.mp4

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers

Copy link

@aprashantz aprashantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about showing a dialog box/bottom sheet when the _currentIndex is 0 rather than directly popping out when back button is pressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants