Fix Regression: Allow toHaveBeenCalledWith and related functions to test calls with no arguments

[benmccormick]

Summary

This PR adds a failing test for the issue identified in #1899 to help expose the issue and prevent future regressions.

Test plan

running npm test in the repo with this change causes tests to fail for now, as expected since Jest16 regresses when testing functions that have been called without arguments.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[benmccormick]

I would love some pointers in terms of fixing this issue. I dug into it a bit last week, but the code around the spy matchers seems to have been heavily refactored in the past release, and I couldn't trace down the regression. I'd be happy to take a pointer to where the code determines which arguments are passed to the matcher, and try to flesh this PR out from there

[cpojer]

@benmccormick check here: https://github.com/facebook/jest/blob/master/packages/jest-matchers/src/spyMatchers.js#L72

[benmccormick]

@cpojer yeah, I got to that point earlier. When that function is called in my basic test

it('can check that a function is called without arguments', () => {
    let fn = jasmine.createSpy();

    fn();
    expect(fn).toHaveBeenCalledWith();
});

calls is set to [ [] ] and expected is set to [undefined] .

What I'm unclear on is where the matcher is called from and what would cause expected to be [undefined] rather than []. That seemed to be in Jasmine land when I looked, but Jasmine didn't change in the version bump, and this worked in v15.

[cpojer]

That should be somewhere around here: https://github.com/facebook/jest/blob/master/packages/jest-matchers/src/index.js#L55

we rewrote this matcher completely as we are trying to kill parts of Jasmine that we don't like :)

[benmccormick]

@cpojer Ah perfect, code was assuming at least one expected argument (function signature of (expected, ...rest) so I've refactored it to just pass all args along to the matcher and things seem fine now. Thanks so much for the help!

[cpojer]

that makes sense! Thank you.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.