Fix testPathPatterns when config is in subdirectory

[brandonchinn178]

Summary

Resolves #14726. No CHANGELOG entry, as it fixes an issue with a new feature that's already in the CHANGELOG.

Follow up to #12519 (which fixes both #10746 and #8226). In this PR, we separate the TestPathPatterns class into two classes: one that just represents the list of patterns and one that can match the patterns against a test file. The separation is necessary because there are some uses where we aren't in a project, and can't match against a regex, but we do want to do static analysis of the patterns. For example, when outputting the test summary, we want to show the patterns the user specified, but the summary is global, not per-project.

I also made a change I had wanted to do in the initial PR, which is store TestPathPatterns directly in GlobalConfig. Now, the fact that patterns are represented as Array<string> is an implementation detail, and everything using the patterns can only use the provided API.

This will make even more sense when rootDir is removed from GlobalConfig, as discussed. It would be even nicer if ProjectConfig stored TestPathPatternsExecutor, but it was getting weird with InitialProjectConfig, so I didn't want to touch that.

Test plan

I wrote a new test that is executed with yarn jest testPathPatterns. It fails on main with "no tests found", and passes on this branch.

[netlify]

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	c22a670
🔍 Latest deploy log	https://app.netlify.com/sites/jestjs/deploys/6642bf571a92de000831be37
😎 Deploy Preview	https://deploy-preview-14934--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[brandonchinn178]

@SimenB Okay CI should be good now!

[SimenB]

so sorry about the slow reply!

The code overall looks good to me, I'd just like to see it not be in @jest/types. I can probably move it myself if you're busy 🙂

[SimenB]

didn't notice this was here before 😅

I don't wanna export non-types from this package. I'm fine with not having it in jest-util, but could you pull it out into its own new package?

[brandonchinn178]

So it can't be in jest-util because jest-util imports from @jest/types and TestPathPatterns is used in GlobalConfig, so there'd be a circular dependency.

But I broke it out into a new jest-pattern library and pushed a commit. Hopefully it builds fine

[SimenB]

I also made a change I had wanted to do in the initial PR, which is store TestPathPatterns directly in GlobalConfig. Now, the fact that patterns are represented as Array<string> is an implementation detail, and everything using the patterns can only use the provided API.

I'm not too sure about this change. Currently the config is JSON serializable - that changes if we stick a class instance on it 🤔

[brandonchinn178]

It should still be JSON serializable, because it implements toJSON

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#toJSON()_behavior

Pretty sure theres a test somewhere checking this

[SimenB]

CI fails now with type errors in the tests. Not sure if that's something we wanna fix, or add the module to the ignore list:

jest/scripts/lintTs.mjs

Lines 32 to 33 in 343d450

	// TODO: remove this list at some point and run against all packages
	const packagesNotToTest = [

[brandonchinn178]

hm I'll take a look

[brandonchinn178]

@SimenB seems like its passing now!