-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import formatting rules from eslint-plugin-jest-formatting
#1563
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
025ebb2
to
e8ea5eb
Compare
d8b49bd
to
f987cb6
Compare
Note that for now I've focused on integrating the rules into our plugin with as minimal changes as possible - there's a few things I'd like to explore refactoring, but I've not found anything actually horribly broken so I think it's better to leave such refactors for a follow-up (or at least for after confirming we want to land this); likewise for adding any new configs. |
066223d
to
b6d8241
Compare
b6d8241
to
df85861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't looked through the code, but in general I'm happy to see this land 🙂
(as long as the maintainers of the existing plugin are OK with it)
@dangreenisrael are you happy for this to happen? |
@G-Rath I can't really speak for @dangreenisrael, but I'm a contributor on the repo in question and I think the best place for this plugin is probably within the Jest community org now that @SimenB has relaxed the rules around style plugins a bit. Assuming Dan wants to donate the package, we'd want to put some kind of notice on the current repo/package to say that the plugin has been adopted by the Jest community. Are there any other changes on Dan's side that would need to happen? I think the current plugin is included in some packages that bundle several plugins together, so we might have to track those down. |
Deprecating on npm is probably enough as people installing would get a warning. Which might be a bit heavy handed of course 😅 |
This explores what it would be like to import the formatting rules from
eslint-plugin-jest-formatting
- I'm a big fan of these rules and have always thought it would make sense to include them as I don't think this is a particularly controversial style.Related: dangreenisrael/eslint-plugin-jest-formatting#122