Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firefox image #527

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update firefox image #527

wants to merge 3 commits into from

Conversation

ngaro
Copy link
Contributor

@ngaro ngaro commented Mar 29, 2020

  • Use bullseye (stable) instead of sid (unstable) as base-image
  • Make it possible to change this at buildtime with the buildarg DEBVERSION
  • Take firefox from bionic (newest LTS) instead of xenial (older LTS)
  • Make it possible to change this at buildtime with the buildarg UBUVERSION
  • Use UTF-8 as default LANG
  • Run it as user user with homedir /home/user
  • Make it possible to change this at buildtime with the buildargs USER and HOME
  • Add example usage in such a way that DIR=firefox make run work

Warning: Users that use firefox both in a container and in the usual way may lose there firefox profile because of -v $HOME/.mozilla:/home/user/.mozilla when the firefox versions are not equal.
So this gives us three options:

  1. I could leave it like this and call it 'wanted behavior' (perfect for users that only use firefox in a container)
  2. I could remove it which will cause the user to lose the container profile every time he restarts it. (perfect for users that only rarely use firefox in a container)
  3. I could change $HOME/.mozilla to another dir, no profile will be lost but it will only work if the user has this dir. (perfect if the user can somehow be forced to make sure that new dir exists)

Opinions please...
(My favorite is the 1st one)

- Add example usage in such a way that `DIR=firefox make run` work
- Use bullseye (stable) instead of sid (unstable) as base-image
- Make it possible to change this at buildtime with the buildarg DEBVERSION
- Take firefox from bionic (newest LTS) instead of xenial (older LTS)
- Make it possible to change this at buildtime with the buildarg UBUVERSION
- Use UTF-8 as default LANG
- Run it as user "user" with homedir "/home/user"
- Make it possible to change this at buildtime with the buildargs USER and HOME
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant