Massive VCF Import – Thrown problematic #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
During a massive import, I noticed a fairly significant loss of data, particularly on telephone numbers which did not have the right type. Example, on an old VCF file extracted from an IMAP, I have lines that look like:
TEL;TYPE=CELL:06 00 00 00 34And
CELLis not part of the authorized category, so because of the Thrown, the data is lost on importI suggest removing these Thrown (ultimately, maybe put a logger to recover the bad data?)
Same for Thrown classes already used, I suggest removing them and exiting the function without stopping everything
Thank you for your time and consideration.