PHP 8.1 - 8.3 + Docker + Github Actions + Refactoring of the code #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plemented phpstan, implemented github actions, implemented DTOs.
nopenopenope
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will complete deprecate PHP7 usage as it was possible years before, as PHP7 is already a long time end of life.
Previous branches can be used if PHP7 is planned to be kept alive.
This PR is also not backwards compatible. I've changed quite some semantics to remove most of the smelly code (i.e. transmit arbitrary strings to functions that require a specific format in order to work as expected).
This PR introduces more things:
Coverage is around ~75%.
Tests are running fine. Scrutinizer is failing to build, but GitHub Actions are in good conditions, see my own PR in my fork: https://github.com/nopenopenope/vcard/actions/runs/7450641541/job/20270001192