Feat/batch get #656
Draft
Feat/batch get #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansform-option Test and improve transform option
…cloning-step-as-well use generators for cloning step as well
…eric-type [v1] Chore : improve type for build methods
…property-on-warm-schemas add and use freeze property on warm schemas
…n-detecting-invalid-item print pk and sk when detecting an invalid saved item
…erties-with-symbols hide operation properties with symbols
…ing-object-timestamp-values fix bug when providing incomplete object timestamp values
guiyom-e
reviewed
Feb 9, 2024
|
|
||
| if (commands.length === 0) { | ||
| throw new DynamoDBToolboxError('operations.incompleteCommand', { | ||
| message: 'BatchGet command incomplete: No items supplied' |
There was a problem hiding this comment.
Suggested change
| message: 'BatchGet command incomplete: No items supplied' | |
| message: 'BatchGet command incomplete: No item supplied' |
guiyom-e
reviewed
Feb 9, 2024
| import { BatchGetOptions } from './options' | ||
|
|
||
| export const buildBatchGetCommandInput = ( | ||
| commands: GetBatchItemRequest[], |
There was a problem hiding this comment.
Suggested change
| commands: GetBatchItemRequest[], | |
| requests: GetBatchItemRequest[], |
guiyom-e
reviewed
Feb 9, 2024
| const TableProjections: { [key: string]: any } = {} | ||
|
|
||
| if (commands.length === 0) { | ||
| throw new DynamoDBToolboxError('operations.incompleteCommand', { |
There was a problem hiding this comment.
Suggested change
| throw new DynamoDBToolboxError('operations.incompleteCommand', { | |
| throw new DynamoDBToolboxError('operations.incompleteOperation', { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.